Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Image path when pushup.js doesn't exist

#5

Hi,

When going in production all my javascripts files got merged and compressed so I don't have any pushup.js file.

This actually makes problem with images options if not defined as full URL (eg: http://domain.tld/images/pushup/). Absolute path should still keep working as not based on pushup javascript location.

Reported by Sébastien Grosjean - ZenCocoon · August 3rd, 2008 @ 10:08 AM

State: invalid
Milestone: none
Assigned to: Nick Stakenburg Nick Stakenburg

Activity

  1. stuartloxton
    stuartloxton

    Would a / path be useful to start from the domain base?

    http://pushup.lighthouseapp.com/...

    Has a similar problem + fix

    August 3rd, 2008 @ 12:07 PM

  2. Nick Stakenburg
    Nick Stakenburg
    • State changed from new to invalid

    It's not possible to change the name of pushup.js. The filename is searched for to get the correct image path. If you rename it, you'll need to change the regexp inside pushup.js to match the new name, I recommend not changing the name at all though.

    August 3rd, 2008 @ 12:09 PM

  3. Sébastien Grosjean - ZenCocoon
    Sébastien Grosjean - ZenCocoon

    If you check at http://villasthalassa.com for example you will see that all my JS are MERGED (there inside, prototype, scriptaculous, swfobject and plenty more), there's then no reason to get my merged JS named pushup.js

    Is there no way to just use the relative path from the JS itself ? Without having to parse the DOM the hack it!

    Anyway fixing the absolute path problem ( #4 Abolute images path ) would allow great flexibility already.

    Hope that helps making even better script,

    Sebastie Grosjean - ZenCocoon

    August 3rd, 2008 @ 12:26 PM

  4. Nick Stakenburg
    Nick Stakenburg

    By doing that you render scriptaculous ability to use scriptaculous.js?load=effects useles. Pushup uses a similar technique, there's no other way to do this.

    August 3rd, 2008 @ 12:29 PM

  5. Sébastien Grosjean - ZenCocoon
    Sébastien Grosjean - ZenCocoon

    I see that you took the same approach as scriptaculous and personally do not use scriptaculous.js?load mechanism but load the libs right aways.

    Anyway that look to be the only way to have relative path and absolute path are comfortable enough so...

    Let's test the absolute path solution ;-)

    August 3rd, 2008 @ 12:57 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.