Pushup Pushup

Comments and changes to this ticket

• 

  stuartloxton August 3rd, 2008 @ 12:06 PM

  Hi,

  I noticed that error to, I've also alerted Nick to the problem. The solution is to use a better regular expression. I can up with this one yesterday (not tested) but pretty sure it will work:

  Replace line 70 of pushup.js:

  if (this.options.images.indexOf('://') > -1)
  

  with:

  if(/^(https?:\/\/|\/)/.test(this.options.images)) 
  

  It SHOULD work, hope it helps

• 

  Nick Stakenburg August 3rd, 2008 @ 12:31 PM

  • → Milestone changed from “” to “1.0.1”

  Thanks, not sure if this is going to work with the PNG images in IE6 though. That'll need some testing before I implement this.

• 

  Sébastien Grosjean - ZenCocoon August 3rd, 2008 @ 01:11 PM

  I've just tested

  on Mac:

  • FF 3.0.1
  • Safari 3.1.2
  • Opera 9.51

  on Win:

  • IE 6
  • IE 7
  • Firefox 2.0.0.16
  • Opera 9.25
  • Safari 3.1

  And all looks fine to me with the images (just some small problems with CSS on mac Opera 9.51, I give a look at it).

• 

  stuartloxton August 3rd, 2008 @ 02:18 PM

  The regex should only extend the functionality already there, and I've tested it so it only accepts http, https and /.

• 

  Nick Stakenburg August 3rd, 2008 @ 02:24 PM

  • → State changed from “new” to “resolved”

  Thanks, I've pushed the fix into 1.0.1.

  Will add a changelog later to track these updates.

  http://github.com/staaky/pushup/...