Abolute images path
Reported by Sébastien Grosjean - ZenCocoon | August 3rd, 2008 @ 09:24 AM | in 1.0.1
Hi,
When using an absolute images path in the options it doesn't make the expected result :
'/images/pushup/' => JavascriptLocation+'/images/pushup/'
Comments and changes to this ticket
-
stuartloxton August 3rd, 2008 @ 12:06 PM
Hi,
I noticed that error to, I've also alerted Nick to the problem. The solution is to use a better regular expression. I can up with this one yesterday (not tested) but pretty sure it will work:
Replace line 70 of pushup.js:
if (this.options.images.indexOf('://') > -1)with:
if(/^(https?:\/\/|\/)/.test(this.options.images))It SHOULD work, hope it helps
-
Nick Stakenburg August 3rd, 2008 @ 12:31 PM
- Milestone set to “1.0.1”
Thanks, not sure if this is going to work with the PNG images in IE6 though. That'll need some testing before I implement this.
-
stuartloxton August 3rd, 2008 @ 02:18 PM
The regex should only extend the functionality already there, and I've tested it so it only accepts http, https and /.
-
Nick Stakenburg August 3rd, 2008 @ 02:24 PM
- State changed from “new” to “resolved”
Thanks, I've pushed the fix into 1.0.1.
Will add a changelog later to track these updates.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Pushup is an effort to push the web forward by helping users update their outdated browsers. Give your users a better web experience today by installing Pushup on your domain!
Nick Stakenburg
